Fix: Apply type defaults to nodes without class attribute#116
Merged
ffAudio merged 1 commit intoffAudio:mainfrom Dec 7, 2025
Merged
Fix: Apply type defaults to nodes without class attribute#116ffAudio merged 1 commit intoffAudio:mainfrom
ffAudio merged 1 commit intoffAudio:mainfrom
Conversation
The Types section in stylesheets was only being checked inside the class iteration loop, meaning nodes without any class attribute would never receive type defaults. This adds the type lookup as a fallback after the class loop.
ffAudio
approved these changes
Dec 7, 2025
Owner
ffAudio
left a comment
There was a problem hiding this comment.
Good idea to expand that lookup.
Thanks for finding that!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Types section in stylesheets was only being checked inside the class iteration loop, meaning nodes without any class attribute would never receive type defaults. This adds the type lookup as a fallback after the class loop.
For example, if you have:
The background color doesn't apply to Views with no class attached to them. If you add any class they do get picked up.