Fixes the X button in the editor UI's behavior for properties with default values#118
Open
isnotinvain wants to merge 1 commit intoffAudio:mainfrom
Open
Fixes the X button in the editor UI's behavior for properties with default values#118isnotinvain wants to merge 1 commit intoffAudio:mainfrom
isnotinvain wants to merge 1 commit intoffAudio:mainfrom
Conversation
…fault values. For properties without default values, the X button moves through 3 states, and alwas moves from state 1 towards state 3: 1) Property is set to a value, eg height="7" 2) Property is set to empty string, eg height="" 3) Property is not set at all This is nice behavior! But it doesn't work that way for properties with default value, like min-width and friends. Those properties just oscillate between states 1 and 2 and can't ever get to 3. This PR fixes that -- I believe the issue has to do w/ callbacks triggering when we don't want them to. This PR also makes a UI style change in that for properties in state 3, we grey out the text showing the user what default value is going to be applied. I think this makes it more clear that there is a default, here's what it is, no it's not set in your xml file explicitly. This also applies to values that were inherited -- you can see what's inherited but we make it clear that it's not set on this node.
ffAudio
approved these changes
Dec 13, 2025
Owner
ffAudio
left a comment
ffAudio
left a comment
There was a problem hiding this comment.
Thank you for that solution.
I experienced the issue, but never had time to track it down.
| if (auto* label = dynamic_cast<juce::Label*>(editor.get())) | ||
| { | ||
| juce::Value disconnected; | ||
| label->getTextValue().referTo (disconnected); |
Owner
There was a problem hiding this comment.
That's weird that there is no other way to reset the value source.
Did you try this?
label->getTextValue().referTo({});
Contributor
Author
There was a problem hiding this comment.
I can try that! I'm not familiar with most of this ecosystem so that's probably just my mistake.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For properties without default values, the X button moves through 3 states, and alwas moves from state 1 towards state 3: 1) Property is set to a value, eg height="7"
2) Property is set to empty string, eg height=""
3) Property is not set at all
This is nice behavior! But it doesn't work that way for properties with default value, like min-width and friends. Those properties just oscillate between states 1 and 2 and can't ever get to 3.
This PR fixes that -- I believe the issue has to do w/ callbacks triggering when we don't want them to.
This PR also makes a UI style change in that for properties in state 3, we grey out the text showing the user what default value is going to be applied. I think this makes it more clear that there is a default, here's what it is, no it's not set in your xml file explicitly. This also applies to values that were inherited -- you can see what's inherited but we make it clear that it's not set on this node.