feat: EC2 2023 8.2-Shear#121
feat: EC2 2023 8.2-Shear#121DanielGMorenaFhecor wants to merge 42 commits intofib-international:dev-ec2-2023from
Conversation
Co-authored-by: talledodiego <38036285+talledodiego@users.noreply.github.com>
…codes into ec_2004_crack_control
mortenengen
left a comment
mortenengen
left a comment
There was a problem hiding this comment.
Thanks for the great contribution 😃
I have merged dev and fixed the docstrings.
There is a significant number of lines that are not covered by tests. Please add tests so that we reach 100% coverage on the added code.
|
I have added tests to cover all 100% lines of code. Also, I have merged changes from |
talledodiego
left a comment
talledodiego
left a comment
There was a problem hiding this comment.
Thanks for this gigantic contribution. This is definitely a massive work!
I finished the review excluded the tests that I will check after the changes requested are performed on the other file.
talledodiego
left a comment
talledodiego
left a comment
There was a problem hiding this comment.
Thanks for this gigantic contribution. This is definitely a massive work!
I finished the review excluded the tests that I will check after the changes requested are performed on the other file.
talledodiego
moved this from Compliance review
to Changes requested
in EC2 2023 PR tracker
|
Thanks a lot, @talledodiego , for taking the time to review this PR, I really appreciate it, especially given the large number of lines to go through. I've addressed all your comments and applied the suggested changes. Please let me know if you spot anything else that needs adjustment! |
talledodiego
moved this from Changes requested
to Review changes
in EC2 2023 PR tracker
talledodiego
left a comment
talledodiego
left a comment
There was a problem hiding this comment.
Excellent revision! Thanks. Some pending comments are still there for your evaluation.
| ) | ||
|
|
||
| k1 = 0.5 * a_cs_0 / (e_p + d / 3) * (A_c / (b_w * z)) | ||
| k1 = 0.5 / a_cs_0 / (e_p + d / 3) * (A_c / (b_w * z)) |
There was a problem hiding this comment.
should this be * instead of /?
* (e_p + d / 3)
| ValueError: If any input values are negative | ||
| or if gamma_v or d are non-positive. |
There was a problem hiding this comment.
I would switch these two:
ValueError: if gamma_v or d are non-posititve or if any other input values are negative
| # Tension case | ||
| cot_theta_min = 2.5 - 0.1 * NEd / abs(VEd) | ||
| cot_theta_min = max(cot_theta_min, 1.0) | ||
| elif NEd < 0: | ||
| # Compression case | ||
| sigma_c = abs(NEd) * 1000 / Ac # Convert to MPa | ||
| if sigma_c >= 0.0 and x < 0.25 * d: | ||
| # Significant compressive stress and x < 0.25d | ||
| # Interpolate: 2.5 at 0 MPa, 3.0 at 3 MPa and above | ||
| # Formula: 2.5 + (3.0-2.5) * sigma_c / (3.0-0.0) | ||
| cot_theta_min = 3.0 if sigma_c >= 3.0 else 2.5 + sigma_c / 6.0 | ||
| else: | ||
| # Use tension formula for other compression cases | ||
| cot_theta_min = 2.5 - 0.1 * NEd / abs(VEd) | ||
| cot_theta_min = max(cot_theta_min, 1.0) |
There was a problem hiding this comment.
I am not interpreting correctly this I guess.
This was my interpretation of EC2:2023
- if Ned = 0 -> 2.5
- if sigma > 3 (there is the strange absolute value that I guess makes no much sense to me) and x <= 0.25 we are in significant axial stress condition -> 3.0
- if sigma is between 0 and 3 in compression -> linear interpolation between 2.5 and 3.0
- if sigma > 3 and x > 0.25 we are in high compression and clause (11) should be applied (not the one for tension?)
3 participants
I have completed the chapter '8.2 - Shear' from the EC2-2023.