Skip to content

fix: area computation on Generic Section #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mortenengen merged 4 commits into from
Aug 9, 2024
Merged

fix: area computation on Generic Section #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c06b47c
Fix area computation on Generic Section
talledodiego Aug 7, 2024
10c53bf
Revert "Fix area computation on Generic Section"
talledodiego Aug 8, 2024
c9c40b1
Merge branch 'dev' into fix-area-computation
talledodiego Aug 8, 2024
d768f91
Removed unecessary area_surface
talledodiego Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions structuralcodes/core/_section_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ class GrossProperties:

# section areas
area: float = field(default=0, metadata={'description': 'Total area'})
area_surface: float = field(
default=0, metadata={'description': 'Surface area'}
)
area_reinforcement: float = field(
default=0, metadata={'description': 'Reinforcement area'}
)
Expand Down
1 change: 0 additions & 1 deletion structuralcodes/sections/_generic.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,6 @@ def _calculate_gross_section_properties(self) -> s_res.GrossProperties:
# and mass: Morten -> problem with units! how do we deal with it?
for geo in self.section.geometry.geometries:
gp.ea += geo.area * geo.material.get_tangent(eps=0)[0]
gp.area_surface += geo.area
if geo.density is not None:
# this assumes area in mm2 and density in kg/m3
gp.mass += geo.area * geo.density * 1e-9
Expand Down