chore: refactor class hierarchy to better avoid circular imports#331
Merged
mortenengen merged 3 commits intodevfrom Mar 18, 2026
Merged
chore: refactor class hierarchy to better avoid circular imports#331mortenengen merged 3 commits intodevfrom
mortenengen merged 3 commits intodevfrom
Conversation
Note that some methods on the SectionCalculator base class that were not general are removed.
talledodiego
approved these changes
Mar 18, 2026
Collaborator
talledodiego
left a comment
talledodiego
left a comment
There was a problem hiding this comment.
Thanks for this. I totally agree with the approach of splitting the different base classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to refactor the class hierarchy so that future additions to the library are less likely to cause circular imports.