fix: guard perimeter computation for MultiPolygon geometries#338
Closed
saschabuehrle wants to merge 1 commit intofib-international:mainfrom
Closed
fix: guard perimeter computation for MultiPolygon geometries#338saschabuehrle wants to merge 1 commit intofib-international:mainfrom
saschabuehrle wants to merge 1 commit intofib-international:mainfrom
Conversation
Collaborator
|
Thanks @saschabuehrle for taking the time to fix this. Thanks for your time! |
Author
|
Ah, missed that #332 already landed. Closing — thanks for letting me know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
#329 —
gross_propertiesraisesAttributeError: 'MultiPolygon' object has no attribute 'exterior'when the section geometry is aMultiPolygon(e.g. disconnected rectangles).Fix
The
if isinstance(polygon, MultiPolygon)block correctly setsgp.perimeter = 0.0and emits a warning, but the code then falls through topolygon.exterior.lengthunconditionally. This adds anelsebranch so the.exterioraccess only runs for singlePolygongeometries.Testing
Verified that the code path now correctly short-circuits for
MultiPolygonand only accesses.exterioron singlePolygoninstances. The existing test suite continues to pass for single-polygon sections.Happy to address any feedback.
Greetings, saschabuehrle