Skip to content
This repository was archived by the owner on Aug 18, 2020. It is now read-only.

Expose more information#11

Open
splitice wants to merge 9 commits into
fidm:masterfrom
HalleyAssist:master
Open

Expose more information#11
splitice wants to merge 9 commits into
fidm:masterfrom
HalleyAssist:master

Conversation

@splitice

Copy link
Copy Markdown
  • Expose if the stream is currently closing
  • Expose the last activity and last network activity
  • Expose if the stream & session has ever had activity

Most of this was used to enable some basic monitoring of the sessions & their streams.

@splitice

splitice commented Jul 23, 2018

Copy link
Copy Markdown
Author

Also:

  • Overwrite default error handler, important due to there being places where errors can occur but the session hasn't been passed through yet
  • Native node end supports a function as argument 1 for end, some libraries pass it in. This causes issues with err which is argument 1. and results in issue Repeated stress leads to unknown error code #12.

@zensh

zensh commented Jul 23, 2018

Copy link
Copy Markdown
Member

👍

@zensh

zensh commented Aug 12, 2018

Copy link
Copy Markdown
Member

@splitice Hi, there are some coding style errors, you should run npm run lint.

@splitice

Copy link
Copy Markdown
Author

Conforming to @fidm's style is is something I can do - if there is a chance of merge and further development.

crypto not complete
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants