This repository was archived by the owner on Apr 26, 2025. It is now read-only.
fix: correct lang parameter condition in redirectToLogin#15
Open
Kori000 wants to merge 1 commit intofief-dev:mainfrom
Open
fix: correct lang parameter condition in redirectToLogin#15Kori000 wants to merge 1 commit intofief-dev:mainfrom
Kori000 wants to merge 1 commit intofief-dev:mainfrom
Conversation
Author
|
Hi @frankie567 Just a gentle follow-up on this PR. Could you please take a look when you have time? It's a small bug fix that might benefit other users. Thank you for your time and the great project! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Description
In the
redirectToLoginmethod, there's an error in the logic for passing thelangparameter. The current code binds thelangparameter to the existence of thestateparameter:This causes the
langparameter to be passed only when thestateparameter exists, making it ineffective when passing only thelangparameter.Fix
Modified the condition to make the
langparameter's transmission depend only on the existence of thelangparameter itself:With this change, the
langparameter will be correctly passed to the authorization URL regardless of whether thestateparameter is provided.