Skip to content

feat(kubernetes-workload): add support to define custom tags for monitors#2

Draft
francovp wants to merge 2 commits into
masterfrom
feat-module-k8s-workload-custom-team-tag
Draft

feat(kubernetes-workload): add support to define custom tags for monitors#2
francovp wants to merge 2 commits into
masterfrom
feat-module-k8s-workload-custom-team-tag

Conversation

@francovp

@francovp francovp commented Aug 10, 2022

Copy link
Copy Markdown
Member

This adds a new "custom_tags" input variable to enable us to define custom tags for all the caas/kubernetes/workload terraform module monitors

@ricmunozt ricmunozt left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marrws marrws left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me parece un cambio bastante simple y sigue la línea de como estaba antes el archivo tf

@marrws

marrws commented Aug 10, 2022

Copy link
Copy Markdown

Este PR es un buen candidato a un squash commit con el mismo mensaje del original. Esto porque cuando lo envies al upstream el commit "Merged PR #xx" aparece en el historial y se ve mal.

Es algo muy menor en todo caso.

@francovp francovp requested review from marrws and vigohe and removed request for abrahamjoc August 11, 2022 13:58
@vigohe

vigohe commented Aug 11, 2022

Copy link
Copy Markdown

provider:kubernetes, resource:kubernetes-workload & created-by:terraform tags should be part of all alerts as default

@marrws marrws left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francovp francovp force-pushed the feat-module-k8s-workload-custom-team-tag branch from 5ef18fd to 8463be6 Compare August 11, 2022 16:52
@francovp

Copy link
Copy Markdown
Member Author

provider:kubernetes, resource:kubernetes-workload & created-by:terraform tags should be part of all alerts as default

Can you review again please. I added provider:kubernetes, resource:kubernetes-workload as locals to easy edit, and add created-by:terraform hard-coded in all monitors

@vigohe

vigohe commented Aug 11, 2022

Copy link
Copy Markdown

provider:kubernetes, resource:kubernetes-workload & created-by:terraform tags should be part of all alerts as default

Can you review again please. I added provider:kubernetes, resource:kubernetes-workload as locals to easy edit, and add created-by:terraform hard-coded in all monitors

better as variable "default_tags"

@francovp

Copy link
Copy Markdown
Member Author

@vigohe done

@francovp francovp force-pushed the feat-module-k8s-workload-custom-team-tag branch from c089a61 to 1eacf73 Compare August 11, 2022 17:11
@vigohe

vigohe commented Aug 11, 2022

Copy link
Copy Markdown

@vigohe done

"created-by:terraform" should be the only one hardcoded

@francovp francovp force-pushed the feat-module-k8s-workload-custom-team-tag branch from 1eacf73 to b72fae0 Compare August 11, 2022 18:28
@francovp

francovp commented Aug 11, 2022

Copy link
Copy Markdown
Member Author

@vigohe done

"created-by:terraform" should be the only one hardcoded

done ✅

@francovp francovp marked this pull request as draft November 17, 2022 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants