ci: allow optional upstream_tag override in Figma release workflow - #19
Merged
Conversation
When cutting a fork release before upstream ships the final tag (e.g. 8.8.0rc1 instead of 8.8.0), pass upstream_tag to verify ancestry and select host Bazel.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit ecc26c0. Configure here.
| echo "## Upstream base" | ||
| echo | ||
| echo "Forked from upstream Bazel **${base}** ([bazelbuild/bazel@\`${upstream_sha}\`](https://github.com/bazelbuild/bazel/releases/tag/${base}))." | ||
| echo "Forked from upstream Bazel **${base}** ([bazelbuild/bazel@\`${upstream_sha}\`](https://github.com/bazelbuild/bazel/releases/tag/${upstream_tag}))." |
There was a problem hiding this comment.
Broken upstream compare link
Low Severity
When upstream_tag differs from the derived base version, release notes still build the compare URL and the “identical to upstream” text from base. For the intended pre-final-tag case that makes the delta link point at a nonexistent upstream tag, even though the notes elsewhere already use the resolved tag.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit ecc26c0. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
upstream_tagworkflow input for releases cut before upstream ships the final tag (e.g.8.8.0rc1instead of8.8.0).USE_BAZEL_VERSION), and release notes.Fixes the failure in https://github.com/figma/bazel/actions/runs/31218370196 where the workflow tried to fetch nonexistent
refs/tags/8.8.0.Test plan
masterref=8.8.0-figmaandupstream_tag=8.8.0rc18.8.0rc1upstream_tagleft blank (defaults to derived base version)