Use bazelisk-valid version scheme 8.6.0-figmaN - #4
Merged
Conversation
The first published release tagged `8.6.0-figma.1` could not be consumed: could not resolve the version '8.6.0-figma.1' to an actual version number: invalid version '8.6.0-figma.1' Bazelisk only accepts a custom version suffix via its "patch" grammar `^(\d+\.\d+\.\d+)-([\w\d]+)$`: a mandatory hyphen after x.y.z, then letters/digits/underscore only — no dots. So `8.6.0-figma.1` (dot) and `8.6.0figma1` (no hyphen) are both rejected; `8.6.0-figma1` is valid. Switch the counter to the dot-free form `<base>-figma<N>` (8.6.0-figma1, 8.6.0-figma2, ...). Rename the resolved `embed_label` output to `version` since it is now the actual release version, tag, asset segment, and --embed_label. Consumers pin with USE_BAZEL_VERSION=figma/8.6.0-figma1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3. The first published release (
8.6.0-figma.1) builds fine but Bazelisk can't consume it:Root cause
Bazelisk validates the version string against a fixed grammar. The only pattern that allows a custom suffix is the patch pattern
^(\d+\.\d+\.\d+)-([\w\d]+)$: a mandatory hyphen afterx.y.z, then[A-Za-z0-9_]+— no dots. Verified against the real regexes:8.6.0-figma.18.6.0figma18.6.0-figma1Fix
Switch the auto-counter to the dot-free form
<base>-figma<N>(8.6.0-figma1,8.6.0-figma2, …). This keeps "figma" in the version, is bazelisk-valid, and avoids the confusing literalrc. Renamed the resolvedembed_labeloutput →version(it's now the release version, tag, asset segment, and--embed_labelall at once).Consumers pin with:
Notes
8.6.0-figma.1tag, so the next run produces8.6.0-figma1.8.6.0-figma.1release should be deleted (I couldn't from here):gh release delete 8.6.0-figma.1 --repo figma/bazel --yes --cleanup-tag.95377ad43a— please confirm the PR shows it before merging (the last commit was dropped on Add Figma Bazel release workflow #1 and Release workflow: auto-derive version + fix linux-arm64 linker #2).🤖 Generated with Claude Code