Publish macOS Intel (darwin-x86_64) release binaries - #8
Merged
Conversation
Convert the single-arch build-darwin job into a matrix mirroring build-linux, adding an Intel macos-13 runner alongside the existing Apple-silicon macos-14 build. Assets follow Bazelisk's <os>-<arch> naming (bazel-<version>-darwin-x86_64, plus the bazel_nojdk flavor and .sha256 sidecars), matching upstream bazelbuild/bazel. Bazelisk's darwin download token for x86_64 is amd64 (as on linux), so the matrix carries bazelisk_arch separately from the published arch. Attestation and release steps already glob over dist/*, and the release job's needs already blocks on all matrix legs, so no other changes are required. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds macOS Intel (
darwin-x86_64) binaries to the Figma Bazel release pipeline, matching howbazelbuild/bazelnames its release assets.The
build-darwinjob is converted into a matrix (mirroring the existingbuild-linuxjob), so darwin now builds both architectures:darwin-arm64macos-14(Apple silicon)bazelisk-darwin-arm64bazel-<ver>-darwin-arm64darwin-x86_64(new)macos-13(Intel)bazelisk-darwin-amd64bazel-<ver>-darwin-x86_64Both
bazel-*andbazel_nojdk-*flavors plus.sha256sidecars are produced for the new arch.Notes
amd64(same quirk as linux), so the matrix carriesbazelisk_archseparately from the publishedarch.subject-path: dist/bazel-*) and release (gh release create … dist/*) already glob over all artifacts, and thereleasejob'sneedsalready blocks on every matrix leg — so no other changes were required.macos-13is GitHub's last Intel hosted runner and is on a deprecation track; once retired, the x86_64 leg will need to cross-compile from an Apple-silicon runner.🤖 Generated with Claude Code