[CI] retry ack upon job finish - #75
Merged
Merged
Conversation
lihao-figma
marked this pull request as ready for review
November 25, 2025 00:26
lihao-figma
force-pushed
the
retry_ack_job
branch
from
November 25, 2025 00:27
3a7530b to
1c8867a
Compare
ebarajas
reviewed
Nov 25, 2025
Comment on lines
+155
to
+159
| eval_script( | ||
| :acknowledge, | ||
| keys: [key('running'), key('processed'), key('owners')], | ||
| argv: [test_key], | ||
| ) == 1 |
Contributor
There was a problem hiding this comment.
Can we add a log for when a test is acknowledged too?
ebarajas
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #sev-2-2025-11-24-sinatra-job-timeouts, we saw some test suite successfully finished but didn't get removed from pending queue. This indicates a potential silent failure when marking in Redis. Catch the exception and retry.