Avoid negative array size when drawing bounding boxes - #38
Merged
Conversation
Member
|
@K-Meech Thank you very much! |
Contributor
Author
|
@ctrueden - I just wanted to check when you think this fix might be available in Fiji? Fiji latest + stable are still using 3D viewer No rush - but this fix would solve a long running issue in one of my plugins, so would be great to know a rough timeline. Thanks! |
Member
|
@K-Meech Sorry for the long delay on this. I have now uploaded 3D_Viewer 5.0.1 to the Fiji-Latest update site. |
Contributor
Author
|
Great - thanks @ctrueden ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #35
This small fix prevents
NegativeArraySizeExceptionwhen drawing the bounding box of certain meshes. E.g. see the corresponding issue (#35) for an example of a planar mesh. This fix comes from a section of the other open pull request on this repo: #22@ctrueden - do let me know if any changes are needed to this PR - happy to update as needed! I've tried to make the fix as minimal as possible, as I know the 3D viewer is old code + isn't updated often. No problem if it can't be merged though - thanks.