Adds "Full Height" action#187
Open
fredrikattebrant wants to merge 2 commits intofikovnik:masterfrom
Open
Conversation
Author
|
Need to add a proper Japanese translation of Full Height in ShiftIt/ja.lproj/Localizable.strings, but as my Japanese is not that good, maybe someone can contribute with this? |
|
Would be great to have the same thing for full width as well! |
morihaya
reviewed
Mar 22, 2018
| "Toggle Zoom" = "ズームの切り替え"; | ||
| "Maximize" = "最大化"; | ||
| "Toggle Full Screen" = "フルスクリーンの切り替え"; | ||
| "Full Height" = "Full Height"; |
There was a problem hiding this comment.
"Full Height" = "縦方向に最大化";
I think the above expression is easy to understand as a Japanese.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was missing a Full Height resize action, similar to double clicking on the top or bottom windows border in Windows 7, so I implemented a first version here. There's some upgrading to XCode 7 also.
Covers a request in the 3rd comment for issue #11.