Conversation
ronniel1
force-pushed
the
ronnie/onprem-test
branch
from
d2a2154 to
f9a8b7b
Compare
Option to deploy installer services inside a pod on the localhost
ronniel1
force-pushed
the
ronnie/onprem-test
branch
from
f9a8b7b to
b6de82b
Compare
| GIT_REVISION := $(shell git rev-parse HEAD) | ||
| APPLY_NAMESPACE := $(or ${APPLY_NAMESPACE},True) | ||
| ROUTE53_SECRET := ${ROUTE53_SECRET} | ||
| CONTAINER_COMMAND = $(shell if [ -x "$(shell command -v docker)" ]; then echo "docker" ; else echo "podman"; fi) |
There was a problem hiding this comment.
If one has docker as well as podman installed, this resolves in docker and then ${CONTAINER_COMMAND} pod create below at line 140 results in docker pod command which is incorrect
There was a problem hiding this comment.
Maybe we just need to to be clear that onprem only works with podman, and exit with a clear message if ${CONTAINER_COMMAND} is docker?
There was a problem hiding this comment.
|
|
||
| stage('test subsystem with podman') { | ||
| steps { | ||
| sh '''export CONTAINER_COMMAND=podman; export SERVICE=quay.io/ocpmetal/bm-inventory:test-onprem; make build-onprem''' |
There was a problem hiding this comment.
build-onprem target is missing. How about adding targets as below
all: build
all-onprem: build-onprem
lint:
golangci-lint run -v
.PHONY: build
build: lint unit-test build-minimal
build-onprem: lint unit-test test-onprem build-minimal
There was a problem hiding this comment.
build-onprem is intended to build the container image. I've updated the Makefile in #376 to include the missing target.
pawanpinjarkar
left a comment
pawanpinjarkar
left a comment
There was a problem hiding this comment.
Added some comments. Please take a look.
|
The final changes are here https://github.com/filanov/bm-inventory/pull/376/files |
4 participants
Option to deploy installer services inside a pod on the localhost