Draft
Conversation
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
commented
Jul 17, 2025
Comment on lines
+49
to
+50
| registeredAt: providerInfo.registeredAt, | ||
| approvedAt: providerInfo.approvedAt, |
Contributor
Author
There was a problem hiding this comment.
Should we present these two timestamps as ISO date strings?
bajtos
commented
Jul 17, 2025
Comment on lines
+30
to
+31
| registeredAt: providerInfo.registeredAt, | ||
| approvedAt: providerInfo.approvedAt, |
Contributor
Author
There was a problem hiding this comment.
Should we present these two timestamps as ISO date strings?
juliangruber
requested changes
Jul 17, 2025
| @@ -0,0 +1,51 @@ | |||
| import { ethers } from 'ethers' | |||
Member
There was a problem hiding this comment.
This information would be cool to be exposed by the PDP explorer. That is the default place for checking out a proof set. Either in the UI, or in their UI. I suggest opening an issue in https://github.com/FilOzone/pdp-explorer, listening which properties were missing
Member
There was a problem hiding this comment.
See for example https://pdp.vxb.ai/calibration/proofsets/484
| @@ -0,0 +1,33 @@ | |||
| import { ethers } from 'ethers' | |||
Member
There was a problem hiding this comment.
As above, this should be covered by https://pdp.vxb.ai/calibration/providers really
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While troubleshooting failed retrievals caused by the retrieval worker not
ignoring providers not approved for Pandora, I wrote two scripts to inspect
on-chain state.
Let's discuss where would be a good home for them and in what form. (I can
imagine converting them into a static website hosted on GH pages.)
feat: add
inspect-proofsethelperfeat: script to list approved providers