Conversation
- Look up inactive and unapproved SPs, as FilBeam includes such SPs in the list of retrieval options - Fix deserialisation of capability values - RPC API returns them as hex-encoded string starting with `0x`, not as a Buffer instance. - Rework the code building the "resolved as" part of the alert message to include more details about the resolved SP Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
juliangruber
approved these changes
Nov 7, 2025
Member
juliangruber
left a comment
There was a problem hiding this comment.
Surprising, but if it works it works 👍
pyropy
approved these changes
Nov 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Look up inactive and unapproved SPs, as FilBeam includes such SPs in the list of retrieval options
Fix deserialisation of capability values - RPC API returns them as hex-encoded string starting with
0x, not as a Buffer instance.Rework the code building the "resolved as" part of the alert message to include more details about the resolved SP
Example output:
My intention is to improve the following alert seen recently in Slack - notice that there is no information about the SP: