refactor: retrieval helpers in a shared package #437
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
Signed-off-by: Miroslav Bajtoš <oss@bajtos.net>
bajtos
commented
Nov 5, 2025
Comment on lines
-19
to
-22
| export async function findInBadBits(env, cid) { | ||
| const badBitsEntry = await getBadBitsEntry(cid) | ||
|
|
||
| const result = await env.DB.prepare('SELECT * FROM bad_bits WHERE hash = ?') |
Contributor
Author
There was a problem hiding this comment.
An unused function that we forgot to remove during the bad-bits DB->KV refactor.
juliangruber
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the discussion in #312
This PR introduces a new monorepo package (
/retrieval) and moves several files frompiece-retrievalsto this new package, with as few changes as necessary.Links: