Port GTK2 drawing primitives to cairo#20
Open
mattmelling wants to merge 2 commits intofillods:masterfrom
Open
Conversation
mattmelling
force-pushed
the
gtk2-cairo
branch
from
41be567 to
abd1947
Compare
To support our GTK3 migration efforts. GTK3 dropped the `gdk_gc_*` functions. This change ports the smeter drawing code to cairo.
To support our GTK3 migration efforts. GTK3 dropped the `gdk_gc_*` functions. This change ports the lcd drawing code to cairo.
mattmelling
force-pushed
the
gtk2-cairo
branch
from
abd1947 to
fdf1a6b
Compare
Contributor
Author
|
Rebased on to master as there were conflicts with the changes in #21 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supporting #13. GTK3 drops support for
gdk_gc_*andgdk_draw_*calls. These commits port those calls to usecairo_*andgdk_cairo_*functions which are supported in later versions of GTK2 as well as GTK3.The LCD has been significantly refactored to centralise all drawing around the
rig_gui_lcd_expose_cbfunction, separating it from widget state updates.I have tested this as much as I can with Hamlib dummy and against my Icom 7300, however was unable to test VFO display updates - any additional testing around this would be appreciated!