Open
Conversation
- Add the ability to place filters before the HTTP service, configurable at the request level - Add the concept of an Authorizer, which is just a filter. - Add some initial Authorizers - Bearer (for pre-shared Bearer tokens) and MAC (for pre-shared MAC tokens) A future PR should contain a full OAuth2 flow implemented in an Authorizer.
This commit makes the following changes: * Enable a new preferred API, `toService`. This API allows for creating a service from a request. Rather than specifying content up-front, you can create a function `Content => Future[Result]` using the `toService` API, which gives a reusable function from a request specification. * Major refactoring of types. All request types have been unified to a single `HTTPRequest` type, which is not path-dependent. A `ClientRequest` type also wraps this with a provided client.
* Use strings for method singleton types (workaround breaking finagle change) * Move code around & remove json dependency from core tests * Update build.sbt based on master
jeremyrsmith
force-pushed
the
to-service-api
branch
from
54fea4d to
fa5b437
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes the following changes:
toService. This API allows for creating a service from a request. Rather than specifying content up-front, you can create a functionContent => Future[Result]using thetoServiceAPI, which gives a reusable function from a request specification.HTTPRequesttype, which is not path-dependent. AClientRequesttype also wraps this with a provided client.Filters now, which composes better with the rest of the finagle ecosystem.