feature: added support for dockerizing final-ci application#1
Open
ireznice wants to merge 1 commit intofinal-ci:masterfrom
Open
feature: added support for dockerizing final-ci application#1ireznice wants to merge 1 commit intofinal-ci:masterfrom
ireznice wants to merge 1 commit intofinal-ci:masterfrom
Conversation
Contributor
|
thanks you for big work. please do following:
|
f8231b1 to
5752d4a
Compare
Contributor
There was a problem hiding this comment.
it is necessary to update User if already exists.
d1721cd to
ef21fe2
Compare
base-image/assets/prepare_version.sh
Outdated
Contributor
There was a problem hiding this comment.
not sure...
Make sence to move settings this variables to env.sh and here simply source env.sh ?
prefer to use "default value", e.g. USER=${USER:-"travis"}
f975782 to
87d3716
Compare
87d3716 to
1ef4985
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.