Skip to content

License change to MIT License (closes #118)#127

Open
tinxx wants to merge 2 commits intofinitespace:masterfrom
tinxx:master
Open

License change to MIT License (closes #118)#127
tinxx wants to merge 2 commits intofinitespace:masterfrom
tinxx:master

Conversation

@tinxx
Copy link
Copy Markdown

@tinxx tinxx commented Apr 23, 2021

This PR changes the license to MIT License (ref. #118).

Copy link
Copy Markdown
Owner

@finitespace finitespace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done. Your attention to deal was superb. Take a look at my comments and let me know your feed back. Unless there are some conventions I am not following or something, those have been my experiences with copyrights. I need to check the copyright one last time. Overall well done.

Comment thread examples/BME280_Modes/BME280_Modes.ino Outdated
SCK (Serial Clock) -> A5 on Uno/Pro-Mini, 21 on Mega2560/Due, 3 Leonardo/Pro-Micro


Copyright (c) 2015-2021 Tyler Glenn, et al.
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep the original year only. We can have a modified date if it is needed to keep dates for newer files or major revisions. Having 2015-2021 will always be something that needs updating.

SCK (Serial Clock) -> D1 on ESP8266


Copyright (c) 2015-2021 Tyler Glenn, Alex Shavlovsky, et al.
Copy link
Copy Markdown
Owner

@finitespace finitespace Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I think I would just like to have the date the original file was written. I don’t really see a need for it to be updated. The copyright really only shows who wrote this code first, so the initial date is really the only one that matters. The github history can show the rest…. Unless someone can provide a valid argument against it….

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @finitespace,

Sorry for the delay.

I have changed the copyright dates for the merge request according to your comments.

Wherever there was a copyright stated in the files I used that even if the created date in the comment statet the previous year.
However, in one case where the copyright statement claimed 2016 but the file was create 2017 (as stated in the comment inside the file), I took the more recent year.

I am not a lawywer and definitely not a copyright expert. I presume that the stated year refers to the time of release, not the time the file was initially created.
That would explain the cases where, e.g., files were created 2015 but the copyright statement states 2016.

Cheers, @tinxx

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @finitespace, any updates?

@tinxx tinxx requested a review from finitespace February 5, 2022 20:23
@tinxx
Copy link
Copy Markdown
Author

tinxx commented Feb 5, 2022

Hey @finitespace, how's it goin? Do you think you could find time to look into the changes?

@tinxx
Copy link
Copy Markdown
Author

tinxx commented Mar 15, 2023

Hey @finitespace, this is a kind reminder of this open PR =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants