Open
Conversation
nrsim
force-pushed
the
lookup-by-provider
branch
from
0f69aca to
e3ef8da
Compare
hiranya911
approved these changes
Feb 5, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Thanks for putting this together. LGTM with a nit.
PS: Is the API proposal for this already approved?
| /// or if the provider user identifier is empty.</exception> | ||
| /// <exception cref="FirebaseAuthException">If a user cannot be found with the specified | ||
| /// provider user identifier.</exception> | ||
| public async Task<UserRecord> GetUserByProviderUidAsync(string providerId, string providerUid) |
Contributor
There was a problem hiding this comment.
Nit: How about calling these provider and providerUid so that they are not off by just one letter?
Member
There was a problem hiding this comment.
hiranya911
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RELEASE NOTE: Implemented a new
GetUserByProviderUidAsync()API to retrieve user accounts by their provider IDs.