refactor: Optimize success count calculation in BatchResponse#837
Merged
jonathanedey merged 3 commits intofirebase:masterfrom Jun 3, 2025
Merged
refactor: Optimize success count calculation in BatchResponse#837jonathanedey merged 3 commits intofirebase:masterfrom
jonathanedey merged 3 commits intofirebase:masterfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
796d166 to
276fd53
Compare
jonathanedey
approved these changes
Jun 3, 2025
Collaborator
jonathanedey
left a comment
There was a problem hiding this comment.
LGTM! Thank you @mingi3314 for the contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discussion
This PR refactors the
BatchResponseclass to optimize the calculation ofsuccess_count. The original implementation used a list comprehension to filter successful responses, which could be inefficient for large datasets. This has been replaced with a generator expression, which improves memory efficiency and maintains clarity.No public API changes have been made. This change only affects the internal logic of the
BatchResponseclass.Testing
API Changes
This change does not affect the public API. It only optimizes internal logic for better performance and readability.