Added minimal support for sending FCM messages in async using HTTP/2#870
Merged
jonathanedey merged 5 commits intofcm-http2from Apr 10, 2025
Merged
Added minimal support for sending FCM messages in async using HTTP/2#870jonathanedey merged 5 commits intofcm-http2from
jonathanedey merged 5 commits intofcm-http2from
Conversation
lahirumaramba
approved these changes
Apr 9, 2025
| error_dict, message = _parse_platform_error(content, status_code) | ||
| exc = None | ||
| if handle_func: | ||
| exc = handle_func(error, message, error_dict) |
Member
There was a problem hiding this comment.
As we discussed offline, let's confirm if this complex code path is necessary for error handling. If it is not, let's clean it up and keep it simple :)
Collaborator
Author
There was a problem hiding this comment.
Looks like we use this map FCM specific errors like:
FCM_ERROR_TYPES = {
'APNS_AUTH_ERROR': ThirdPartyAuthError,
'QUOTA_EXCEEDED': QuotaExceededError,
'SENDER_ID_MISMATCH': SenderIdMismatchError,
'THIRD_PARTY_AUTH_ERROR': ThirdPartyAuthError,
'UNREGISTERED': UnregisteredError,
}
We map to these errors by parsing the error response details. The default handle_func (handle_X_error) is agnostic to the source service of the error and doesn't try to parse based the error response details. FCM is the only service that currently makes use of this optional handle_func but this seems like the correct way to support this scenario.
We could move the logic from the helper function _handle_func_X to handle_platform_error_from_X.
Will merge as is and we can revisit this in a follow up PR if necessary.
| google-cloud-storage >= 1.37.1 | ||
| pyjwt[crypto] >= 2.5.0 No newline at end of file | ||
| pyjwt[crypto] >= 2.5.0 | ||
| httpx[http2] == 0.28.1 No newline at end of file |
Member
There was a problem hiding this comment.
let's add this new dependency to setup.py
jonathanedey
added a commit
that referenced
this pull request
Jun 3, 2025
…or FCM async and HTTP/2 support (#882) * Added minimal support for sending FCM messages in async using HTTP/2 (#870) * httpx async_send_each prototype * Clean up code and lint * fix: Add extra dependancy for http2 * fix: reset message batch limit to 500 * fix: Add new import to `setup.py` * Refactored retry config into `_retry.py` and added support for exponential backoff and `Retry-After` header (#871) * Refactored retry config to `_retry.py` and added support for backoff and Retry-After * Added unit tests for `_retry.py` * Updated unit tests for HTTPX request errors * Address review comments * Added `HttpxAsyncClient` wrapper for `httpx.AsyncClient` and support for `send_each_for_multicast_async()` (#878) * Refactored retry config to `_retry.py` and added support for backoff and Retry-After * Added unit tests for `_retry.py` * Updated unit tests for HTTPX request errors * Add HttpxAsyncClient to wrap httpx.AsyncClient * Added forced refresh to google auth credential flow and fixed lint * Added unit tests for `GoogleAuthCredentialFlow` and `HttpxAsyncClient` * Removed duplicate export * Added support for `send_each_for_multicast_async()` and updated doc string and type hints * Remove duplicate auth class * Cover auth request error case when `requests` request fails in HTTPX auth flow * Update test for `send_each_for_multicast_async()` * Address review comments * fix lint and some types * Address review comments and removed unused code * Update metric header test logic for `TestHttpxAsyncClient` * Add `send_each_for_multicast_async` to `__all__` * Apply suggestions from TW review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds basic logic for sending FCM messages in async using HTTP/2
This initial PR covers:
send_each_async()