Refactored retry config into _retry.py and added support for exponential backoff and Retry-After header#871
Merged
jonathanedey merged 4 commits intofcm-http2from May 21, 2025
Merged
Conversation
Member
lahirumaramba
left a comment
lahirumaramba
left a comment
There was a problem hiding this comment.
Thanks Jonathan! Overall looking good! Added a few comments!
firebase_admin/_retry.py
Outdated
|
|
||
| def __init__( | ||
| self, | ||
| status: int = 10, |
Member
There was a problem hiding this comment.
Would it make sense to call this max_retries instead?
Collaborator
Author
There was a problem hiding this comment.
In the current state yes because status retries are our only retries we have. This was more of a future proof decision for when we added error retires where we would have total, status and error counters.
Similar to the placeholder comment I think we can use max_retries (and retries_left internally since we decrease this value) and add the other options later.
| response, error = None, None | ||
|
|
||
| try: | ||
| logger.debug('Sending request in _dispatch_with_retry(): %r', request) |
Member
There was a problem hiding this comment.
Do we plan to keep these logs in the production code?
Collaborator
Author
There was a problem hiding this comment.
I would want to keep these for future debugging. This would be helpful to catch issues as we iterate. Wdyt?
jonathanedey
added a commit
that referenced
this pull request
Jun 3, 2025
…or FCM async and HTTP/2 support (#882) * Added minimal support for sending FCM messages in async using HTTP/2 (#870) * httpx async_send_each prototype * Clean up code and lint * fix: Add extra dependancy for http2 * fix: reset message batch limit to 500 * fix: Add new import to `setup.py` * Refactored retry config into `_retry.py` and added support for exponential backoff and `Retry-After` header (#871) * Refactored retry config to `_retry.py` and added support for backoff and Retry-After * Added unit tests for `_retry.py` * Updated unit tests for HTTPX request errors * Address review comments * Added `HttpxAsyncClient` wrapper for `httpx.AsyncClient` and support for `send_each_for_multicast_async()` (#878) * Refactored retry config to `_retry.py` and added support for backoff and Retry-After * Added unit tests for `_retry.py` * Updated unit tests for HTTPX request errors * Add HttpxAsyncClient to wrap httpx.AsyncClient * Added forced refresh to google auth credential flow and fixed lint * Added unit tests for `GoogleAuthCredentialFlow` and `HttpxAsyncClient` * Removed duplicate export * Added support for `send_each_for_multicast_async()` and updated doc string and type hints * Remove duplicate auth class * Cover auth request error case when `requests` request fails in HTTPX auth flow * Update test for `send_each_for_multicast_async()` * Address review comments * fix lint and some types * Address review comments and removed unused code * Update metric header test logic for `TestHttpxAsyncClient` * Add `send_each_for_multicast_async` to `__all__` * Apply suggestions from TW review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds more retry logic support
This PR covers:
HttpxRetryTransportto_retry.pyHttpxRetryto manage retry stateHttpxRetryTransportcreationRetry-Afterheaders from request responsesHttpxRetryandHttpxRetryTransport