chore(deps): Resolved CI test failures caused by unmocked universe_domain lookups#954
Open
lahirumaramba wants to merge 1 commit into
Open
chore(deps): Resolved CI test failures caused by unmocked universe_domain lookups#954lahirumaramba wants to merge 1 commit into
lahirumaramba wants to merge 1 commit into
Conversation
…redential Added a universe_domain property override to MockGoogleComputeEngineCredential in tests/testutils.py to prevent unexpected network requests to the GCE metadata server during test runs with newer versions of google-auth.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Recent releases of
google-authintroduced universe domain verification duringbefore_requestcalls. For Compute Engine credentials, this verifiesuniverse_domain, which attempts to query the Google Compute Engine metadata service athttp://metadata.google.internal/computeMetadata/v1/universe/universe-domain.Because
MockGoogleComputeEngineCredentialdid not mock theuniverse_domainproperty, CI test runners failed to resolvemetadata.google.internal, causing network timeout errors during test execution.This change overrides the
universe_domainproperty onMockGoogleComputeEngineCredentialintests/testutils.pyto return'googleapis.com', preventing external metadata server lookups during unit tests.