Update source map upload command options

[tonybaroneee]

• Remove telemetryServerUrl option
• Change mapping file positional argument from required to optional (defaults to root dir)

Feedback from API design.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the crashlytics:sourcemap:upload command based on API design feedback. It streamlines the command by removing an unnecessary telemetry server URL option and enhances flexibility by making the mapping file argument optional. These changes simplify the command's usage and reduce configuration overhead for users.

Highlights

• Telemetry Server URL Option Removal: The --telemetry-server-url option has been removed from the crashlytics:sourcemap:upload command, along with its associated validation logic and test case.
• Optional Mapping File Argument: The mappingFiles positional argument for the crashlytics:sourcemap:upload command is now optional, defaulting to the root directory if not provided. This change involved updating the command signature and handling undefined values in the file path resolution.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/commands/crashlytics-sourcemap-upload.spec.ts
  • Removed a test case that validated the presence of the --telemetry-server-url option.
• src/commands/crashlytics-sourcemap-upload.ts
  • Updated the command definition to make the mappingFiles argument optional.
  • Removed the --telemetry-server-url option from the command.
  • Removed the call to checkTelemetryServerUrl from the command's action handler.
  • Modified the mappingFiles parameter type in the action handler to string | undefined.
  • Adjusted the filePath calculation to handle cases where mappingFiles is undefined.
  • Deleted the checkTelemetryServerUrl utility function.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the crashlytics:sourcemap:upload command by removing the telemetryServerUrl option and making the mapping file argument optional. The changes also include removing a test case related to the telemetryServerUrl option and updating the command definition to reflect the optional mapping file argument.