fix(mcp): write firebase-debug.log to ~/.firebase/ instead of cwd#9998
fix(mcp): write firebase-debug.log to ~/.firebase/ instead of cwd#9998VishnuVardhanBR wants to merge 2 commits intofirebase:mainfrom
Conversation
When the Firebase MCP server starts, it calls useFileLogger() which writes firebase-debug.log to process.cwd(). This pollutes the user's project directory with an unrelated file, especially in projects that have no Firebase configuration. Write the MCP debug log to ~/.firebase/firebase-debug.log instead, creating the directory if needed. This matches the pattern of other Firebase tooling that uses ~/.firebase/ as a home for non-project data. Fixes firebase#9982
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves an issue where the Firebase MCP server would create a Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses the issue of firebase-debug.log being created in the user's current working directory by redirecting it to ~/.firebase/. The implementation is straightforward and effective. I've added a couple of suggestions to use asynchronous file system operations, which is a better practice within an async function context to avoid blocking the event loop.
Address code review feedback: use fs/promises mkdir with await instead of the synchronous mkdirSync, since mcp() is already async. This avoids blocking the event loop.
Problem
When the Firebase MCP server starts (via
firebase mcp), it callsuseFileLogger()unconditionally.useFileLogger()callsfindAvailableLogFile()which writesfirebase-debug.logtoprocess.cwd(). This pollutes the user's project directory with an unrelated file on every MCP server startup — even in projects that have no Firebase configuration at all.Fixes #9982.
Root Cause
In
src/bin/mcp.ts:And in
src/logger.ts,findAvailableLogFile()hardcodes the log path toprocess.cwd():Fix
Pass an explicit log file path to
useFileLogger()when starting in MCP mode. The log is redirected to~/.firebase/firebase-debug.log, which:logger.tsTesting
Manually verified by running
npx firebase-tools mcpin a non-Firebase directory and confirming:firebase-debug.logis created in the working directory~/.firebase/firebase-debug.logis created with expected debug output