Skip to content

fix(mcp): write firebase-debug.log to ~/.firebase/ instead of cwd#9998

Open
VishnuVardhanBR wants to merge 2 commits intofirebase:mainfrom
VishnuVardhanBR:fix/mcp-debug-log-cwd-pollution
Open

fix(mcp): write firebase-debug.log to ~/.firebase/ instead of cwd#9998
VishnuVardhanBR wants to merge 2 commits intofirebase:mainfrom
VishnuVardhanBR:fix/mcp-debug-log-cwd-pollution

Conversation

@VishnuVardhanBR
Copy link

Problem

When the Firebase MCP server starts (via firebase mcp), it calls useFileLogger() unconditionally. useFileLogger() calls findAvailableLogFile() which writes firebase-debug.log to process.cwd(). This pollutes the user's project directory with an unrelated file on every MCP server startup — even in projects that have no Firebase configuration at all.

Fixes #9982.

Root Cause

In src/bin/mcp.ts:

process.env.IS_FIREBASE_MCP = "true";
useFileLogger(); // writes to process.cwd()/firebase-debug.log

And in src/logger.ts, findAvailableLogFile() hardcodes the log path to process.cwd():

const logFilename = path.join(process.cwd(), c);

Fix

Pass an explicit log file path to useFileLogger() when starting in MCP mode. The log is redirected to ~/.firebase/firebase-debug.log, which:

  • Is already used by Firebase tooling for non-project data
  • Keeps the user's working directory clean
  • Requires no changes to logger.ts
const mcpLogDir = join(homedir(), ".firebase");
mkdirSync(mcpLogDir, { recursive: true });
useFileLogger(join(mcpLogDir, "firebase-debug.log"));

Testing

Manually verified by running npx firebase-tools mcp in a non-Firebase directory and confirming:

  • No firebase-debug.log is created in the working directory
  • ~/.firebase/firebase-debug.log is created with expected debug output

When the Firebase MCP server starts, it calls useFileLogger() which
writes firebase-debug.log to process.cwd(). This pollutes the user's
project directory with an unrelated file, especially in projects that
have no Firebase configuration.

Write the MCP debug log to ~/.firebase/firebase-debug.log instead,
creating the directory if needed. This matches the pattern of other
Firebase tooling that uses ~/.firebase/ as a home for non-project data.

Fixes firebase#9982
@google-cla
Copy link

google-cla bot commented Mar 2, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue where the Firebase MCP server would create a firebase-debug.log file directly in the current working directory upon startup, leading to unnecessary file clutter. The solution redirects this log file to the ~/.firebase/ directory, which is a standard location for Firebase tooling's non-project specific data, ensuring user project directories remain clean.

Highlights

  • Log File Redirection: The Firebase MCP server's firebase-debug.log file is now written to ~/.firebase/firebase-debug.log instead of the current working directory, preventing pollution of user project folders.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses the issue of firebase-debug.log being created in the user's current working directory by redirecting it to ~/.firebase/. The implementation is straightforward and effective. I've added a couple of suggestions to use asynchronous file system operations, which is a better practice within an async function context to avoid blocking the event loop.

Address code review feedback: use fs/promises mkdir with await
instead of the synchronous mkdirSync, since mcp() is already async.
This avoids blocking the event loop.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MCP] firebase-debug.log is created in user's working directory on every MCP server startup

1 participant