chore: agent skill for helping users setup with FirebaseUI Auth#1364
Open
russellwheatley wants to merge 3 commits into
Open
chore: agent skill for helping users setup with FirebaseUI Auth#1364russellwheatley wants to merge 3 commits into
russellwheatley wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new skill definition for AI agents to assist in setting up FirebaseUI Web across React, shadcn/ui, and Angular projects. The documentation provides detailed workflows, dependency requirements, and implementation patterns for each framework. Feedback from the review focuses on improving the robustness of the provided code snippets by ensuring that all variables, such as firebaseConfig and navigate, and types like ApplicationConfig, are either defined or clearly marked as placeholders to prevent the generation of invalid code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.