Skip to content

fix: transaction outbox exceptions #430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobAtchley merged 2 commits into from
Feb 4, 2026
Merged

fix: transaction outbox exceptions #430

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b254d52
fix: transaction outbox exceptions
Feb 4, 2026
7e0e421
log
Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion Firebend.AutoCrud.Core/Implementations/Entities/InMemoryEntityTransactionOutbox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,19 @@
using Firebend.AutoCrud.Core.Extensions;
using Firebend.AutoCrud.Core.Interfaces.Services.Entities;
using Firebend.AutoCrud.Core.Models.Entities;
using Microsoft.Extensions.Logging;

namespace Firebend.AutoCrud.Core.Implementations.Entities;

public class InMemoryEntityTransactionOutbox : IEntityTransactionOutbox
{
private readonly Dictionary<string, List<EntityTransactionOutboxEnrollment>> _enrollments = new();
private readonly ILogger<InMemoryEntityTransactionOutbox> _logger;

public InMemoryEntityTransactionOutbox(ILogger<InMemoryEntityTransactionOutbox> logger)
{
_logger = logger;
}

public async Task AddEnrollmentAsync(EntityTransactionOutboxEnrollment enrollment, CancellationToken cancellationToken)
{
Expand Down Expand Up @@ -69,7 +76,13 @@ public async Task InvokeEnrollmentsAsync(string transactionId, CancellationToken
})
.ToArray();

await Task.WhenAll(tasks);
var exceptions = (await Task.WhenAll(tasks)).Where(x => x is not null);

if (exceptions.Any())
{
_logger.LogError("One or more enrollment actions failed for transaction {TransactionId}", transactionId);
throw new AggregateException("One or more enrollment actions failed", exceptions);
}

_enrollments.Remove(transactionId);
}
Expand Down