Better icon for Add collection in Collections tab#173
Open
Siddhant-K-code wants to merge 1 commit intofirecamp-dev:mainfrom
Open
Better icon for Add collection in Collections tab#173Siddhant-K-code wants to merge 1 commit intofirecamp-dev:mainfrom
Add collection in Collections tab#173Siddhant-K-code wants to merge 1 commit intofirecamp-dev:mainfrom
Conversation
|
| Name | Link |
|---|---|
| 🔨 Latest commit | a35b684 |
Contributor
|
Thanks for sharing the PR @Siddhant-K-code , I am wondering about its UX, The Can we change the folder menu icon instead? We can keep the same icon shown in folder list IMO. Or else do you mind to suggest some other icons here? We can choose best from multiple options. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updated new icon
BookPlusforAdd new collectionbutton in Collections tab so that it's easily differentiatedAdd a new folder. Related #153(i).I also added a
titleto each of the icons for better accessibility and to show the text on hover.Changes in Visuals
Screen.Recording.2024-01-20.at.12.49.14.PM.mov