variational solver will raise a warning for unused options#4690
Closed
JHopeCollins wants to merge 2 commits intomainfrom
Closed
variational solver will raise a warning for unused options#4690JHopeCollins wants to merge 2 commits intomainfrom
JHopeCollins wants to merge 2 commits intomainfrom
Conversation
JHopeCollins
commented
Oct 31, 2025
| # TODO RELEASE | ||
| # "petsc4py==3.24.0", | ||
| "petsctools", | ||
| "petsctools @ git+https://github.com/firedrakeproject/petsctools.git@JHopeCollins/warn_unused_options", |
Member
Author
There was a problem hiding this comment.
Revert before merge:
Suggested change
| "petsctools @ git+https://github.com/firedrakeproject/petsctools.git@JHopeCollins/warn_unused_options", | |
| "petsctools", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
petsctoolsimplementation now just relies on the user passing-options_leftor not, so there's no need to change anything in Firedrake.I bumped the implementation in #3999 up to petsctools in firedrakeproject/petsctools#21. This PR just adds a call to the newOptionsManager.warn_unused_optionsmethod at the end of thesolvecall.