Open
Conversation
connorjward
commented
Mar 20, 2026
| return family.reconstruct(cell=cell) | ||
|
|
||
| if family in {"R", "Real"} and degree is None: | ||
| degree = 0 |
Contributor
Author
There was a problem hiding this comment.
@pbrubeck under what circumstances do we allow degree to be None? I shoved this hack in but it is gross and likely should live in FIAT/FInAT/finat.ufl
Contributor
There was a problem hiding this comment.
Degree being None means the lowest order for which this element still makes sense
Contributor
There was a problem hiding this comment.
A common mistake is to not pass the degree when creating the R space. I think we should enable degree=None for DG in FIAT to mean degree=0, and similarly for other spaces.
Contributor
Author
There was a problem hiding this comment.
OK. I'll open a precursor PR then that does that.
Contributor
There was a problem hiding this comment.
This should live in fiat/discontinuous_lagrange.py. Just make degree a kwarg in the constructor.
pbrubeck
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(currently incomplete) fixes needed for firedrakeproject/fiat#237