Fix compatibility with scikit-learn 1.8+#99
Merged
firefly-cpp merged 1 commit intofirefly-cpp:masterfrom Dec 4, 2025
Merged
Conversation
scikit-learn 1.8.0+ removed the algorithm parameter from AdaBoostClassifier scikit-learn/scikit-learn#32262 The changes maintain compatibility with previous version of scikit-learn
Owner
|
Thanks, @stratakis! |
Owner
|
@stratakis, should we also update the pyproject.toml and poetry.lock files to version 1.8 or higher? |
Contributor
Author
This change works fine with version 1.6, as the algorithm parameter was deprecated at that version, so no need for updating the dependency pin. Not sure about the CI though, it seems the macos build is failing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scikit-learn 1.8.0+ removed the algorithm parameter from AdaBoostClassifier
scikit-learn/scikit-learn#32262
The changes maintain compatibility with previous version of scikit-learn
❗ Issue Links
Fixes #98
🧪 How Has This Been Tested?
I've tested it on Fedora Rawhide with both scikit-learn 1.7.2 and scikit-learn 1.8.0rc1 and all the tests pass
✅ Checklist