Refactored TCXRead initializer into load_file and parse.#7
Merged
firefly-cpp merged 1 commit intofirefly-cpp:mainfrom Oct 22, 2025
Merged
Refactored TCXRead initializer into load_file and parse.#7firefly-cpp merged 1 commit intofirefly-cpp:mainfrom
firefly-cpp merged 1 commit intofirefly-cpp:mainfrom
Conversation
Owner
|
Dear @dblock, Thank you for reporting the issue and providing a fix. The next logical step is to release a new version (I will do it tonight). Feel free to add additional functionalities. I recall we didn’t support all features from the TCX files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After trying to use TCXRead in dblock/strava-ruby-client@85b501d ...
Refactored the implementation to support loading raw data (not always a file).
Instead of
TCXRead.new, useload_fileandparse..newshould never be used and could go away, could just delete that and do a major version bump.new, because you can have a file path or raw data as aString, so all the libraries likeJSONsupportloadandparse.load_filetoloadif you think it's more idiomatic.Gemfile.lockbecause this is a library.setup.