fix: add missing deps, fix Union import, remove redundant DB query#208
Open
utkarshqz wants to merge 1 commit intofireform-core:mainfrom
Open
fix: add missing deps, fix Union import, remove redundant DB query#208utkarshqz wants to merge 1 commit intofireform-core:mainfrom
utkarshqz wants to merge 1 commit intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes four bugs discovered during local setup and end-to-end testing of the API.
A fresh
pip install -r requirements.txton a clean environment fails immediately becausepython-multipart(required by FastAPI for file uploads) andpypdf(imported inapi/routes/templates.py) are missing from the dependency list. Additionally,api/main.pyraises aNameErroron startup due to a missingUnionimport, andPOST /forms/fillmakes a redundant database query on every request.Fixes #204
Fixes #187
Fixes #135
Fixes #149
Fixes #145
Type of change
How Has This Been Tested?
Tested on Windows 11, Python 3.11, clean virtual environment.
python -m venv venv && venv\Scripts\activatepip install -r requirements.txt— all packages install without errorsuvicorn api.main:app --reload— no NameError on startupPOST /templates/create— succeeds (previously failed withpython-multiparterror)POST /forms/fill— single DB query confirmed in SQLAlchemy logsTest Configuration:
Checklist: