fix: replace undefined Fill class with Controller in run_pdf_fill_process#216
Open
lakshsarda137 wants to merge 1 commit intofireform-core:mainfrom
Open
fix: replace undefined Fill class with Controller in run_pdf_fill_process#216lakshsarda137 wants to merge 1 commit intofireform-core:mainfrom
lakshsarda137 wants to merge 1 commit intofireform-core:mainfrom
Conversation
…cess Fill.fill_form() causes NameError as Fill is never imported. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NameErrorcaused by undefinedFillclass inrun_pdf_fill_process()Controller().fill_form()which is properly imported and used elsewhere in the codebaseFixes #215
Test plan
run_pdf_fill_process()can be called withoutNameError