feat: Add LLM Confidence Validation and Human-In-The-Loop review (Fixes #222)#223
Open
RITVIKKAMASETTY wants to merge 1 commit intofireform-core:mainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR addresses the critical liability risk of the LLM silently hallucinating missing or ambiguous fields (like names, badge numbers, or incident codes) directly onto official PDF documents.
It implements a "Human-in-the-loop" validation pipeline by updating the LLM extraction to output structured JSON with confidence scores.
Changes Made
src/llm.pynow uses prompt engineering to guarantee Mistral returns JSON ({"value": "...", "confidence": 0.95}).confidence < 0.85are intercepted instead of blindly trusted.src/filler.pynow maps values by explicit semantic field names, and writes[REVIEW REQUIRED]into the PDF for any low-confidence fields so responders can spot them instantly.needs_reviewJSON column toapi/db/models.pyand the FastAPI response schema so the frontend can highlight flagged fields in the UI.Testing Performed
tests/test_llm_confidence.pycovering high/low confidence branching, edge cases, and JSON parse failures (6 passing tests).Fixes #222