Show counter values over time in profiler-cli#6136
Open
fatadel wants to merge 2 commits into
Open
Conversation
fatadel
changed the title
pq counter info
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6136 +/- ##
==========================================
+ Coverage 83.43% 83.44% +0.01%
==========================================
Files 342 342
Lines 36356 36449 +93
Branches 10099 10132 +33
==========================================
+ Hits 30333 30415 +82
- Misses 5595 5607 +12
+ Partials 428 427 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
canova
requested changes
Jul 3, 2026
Member
|
Ah another thing I noticed while looking at the PRs. Could you please change the PR title and the commit message to include "cli"? Maybe something like |
fatadel
changed the title
Add an "over time" section to counter info that splits the current view into time buckets, so a counter's trajectory is visible rather than only an aggregate. Each slice shows the graph-type-appropriate value (level and delta for accumulated counters, the amount for rate counters), its share of the range, and a CO2e estimate where the schema requests one. Values reuse the tooltip formatters and ts-N time names, matching the timeline. A fixed-width sparkline of the trajectory is drawn alongside, in both `counter info` and `counter list`. Closes firefox-devtools#6112
- Scale the sparkline per graph type: relative (min-max) for accumulated counters, absolute for rate counters (process CPU pinned to 0-100%). - Compute process-CPU ratios with the range-scoped max, matching the timeline tooltip. - Exclude the padded boundary samples from the range's counts, sums, and time span. - Rename the internal bucket types and helper (drop "binned"). - Trim the guide's counters section.
Contributor
Author
|
Thanks for your review, @canova! I've addressed all the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
Add an "over time" section to counter info that splits the current view into time buckets, so a counter's trajectory is visible rather than only an aggregate. Each slice shows the graph-type-appropriate value (level and delta for accumulated counters, the amount for rate counters), its share of the range, and a CO2e estimate where the schema requests one. Values reuse the tooltip formatters and ts-N time names, matching the timeline.
A fixed-width sparkline of the trajectory is drawn alongside, in both
counter infoandcounter list.Closes #6112
An example profile to explore - https://share.firefox.dev/4xQbTNj.
Two main changes: