Suggest enabling the "JavaScript Sources" feature in the source view#6144
Suggest enabling the "JavaScript Sources" feature in the source view#6144canova wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6144 +/- ##
==========================================
+ Coverage 83.46% 83.48% +0.02%
==========================================
Files 342 342
Lines 36346 36349 +3
Branches 10208 10211 +3
==========================================
+ Hits 30335 30346 +11
+ Misses 5583 5575 -8
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| # enabled in the recording settings before capturing a profile. | ||
| # "JavaScript Sources" and "about:profiling" should not be translated. | ||
| SourceView--enable-js-sources-feature-hint = | ||
| To view the source of this JavaScript file, enable the “JavaScript Sources” feature in the recording settings on about:profiling before recording the profile. |
There was a problem hiding this comment.
| To view the source of this JavaScript file, enable the “JavaScript Sources” feature in the recording settings on about:profiling before recording the profile. | |
| To view the source of this JavaScript file, before recording the profile enable the “JavaScript Sources” feature in the recording settings in about:profiling. |
I would probably turn it around a bit for readability.
on about:profiling, or in?
There was a problem hiding this comment.
Thanks, updated the wording.I'm very bad in general with English prepositions so I'll take your word for it! 😄
When source code fails to load for a JS source, show a hint pointing users to the "JavaScript Sources" recording feature on about:profiling. The hint only appears when the source has a valid id, so it doesn't show for native or other files. Fixes firefox-devtools#5640
|
At what point can we make that feature always-on (i.e. remove it)? |
I'm not super sure if we want to remove the feature completely. I filed a bug to make it on by default for the "Web Developer" preset here, but I wasn't sure if we wanted to make it on by default in the platform preset yet (we might as well do it?). And I was also thinking that it might make sense to make it off by default on some cases like graphics/media presets. |
mstange
left a comment
mstange
left a comment
There was a problem hiding this comment.
Seems fine but I don't understand how this distinguishes just-captured profiles from uploaded profiles. Do uploaded profiles not have valid source IDs? Why not?
Ok, continuing this conversation there. In the meantime I'm fine with this fix. |
3 participants
Main | Deploy preview
When source code fails to load for a JS source, show a hint pointing users to the "JavaScript Sources" recording feature on about:profiling. The hint only appears when the source has a valid id, so it doesn't show for native or other files.
Fixes #5640
I also had an older PR in #5643 that was trying to achieve something similar that I decided not to land. It was always adding this suggestion no matter what, and the reason was that we didn't have the source table fully available at the time. Now that we always output the source table, we can check and only warn the users when the source table entry has an Id.