Add an early throw for the this.querier and remove the non-null asserts in the cli codebase#6145
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6145 +/- ##
=======================================
Coverage 83.43% 83.43%
=======================================
Files 342 342
Lines 36356 36356
Branches 10099 10195 +96
=======================================
Hits 30333 30333
Misses 5595 5595
Partials 428 428 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ts in the cli codebase
fatadel
approved these changes
Jul 6, 2026
fatadel
left a comment
Contributor
There was a problem hiding this comment.
Thanks for easing the devs' lives! 😁
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main | Deploy preview
This is only a refactor without changing the behavior. I wanted to remove these TS non-null asserts for a while. Now this function checks the
this.querierat the start of the function and early throws, which allows TS to reduce the type to non-null, so we don't have to include!every time we access it.