Skip to content

Remove unused samples.thread column#6151

Open
mstange wants to merge 1 commit into
firefox-devtools:mainfrom
mstange:push-xxpomkrrlpwz
Open

Remove unused samples.thread column#6151
mstange wants to merge 1 commit into
firefox-devtools:mainfrom
mstange:push-xxpomkrrlpwz

Conversation

@mstange

@mstange mstange commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Main | Deploy preview

This was added by the merging/diffing code and propagated in various places, but never actually read. There is a possibility that we may want to make use of this field in the future, but it's been many years and it hasn't happened, so let's just remove it for now. We can always add it back once we need it.

I noticed it because it ends up in the "compact" speedometer profiles from CI via profiler-edit --merge-non-overlapping-threads-by-name.

This was added by the merging/diffing code and propagated in various
places, but never actually read. There is a possibility that we may
want to make use of this field in the future, but it's been many years
and it hasn't happened, so let's just remove it for now. We can always
add it back once we need it.
@mstange mstange requested a review from canova July 7, 2026 18:48
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.50%. Comparing base (b2c0eba) to head (7bc758e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6151    +/-   ##
========================================
  Coverage   83.50%   83.50%            
========================================
  Files         342      342            
  Lines       36522    36510    -12     
  Branches    10224    10118   -106     
========================================
- Hits        30497    30487    -10     
+ Misses       5597     5596     -1     
+ Partials      428      427     -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant