Skip to content

Make sure tests fail if typecheck fails #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Gawor270 merged 3 commits into from
Mar 25, 2026
Merged

Make sure tests fail if typecheck fails #508

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e73a79
remove "or echo" part from typecheck
Gawor270 Mar 25, 2026
6470d81
test if only tsc fails
Gawor270 Mar 25, 2026
cbf3cfc
Revert "test if only tsc fails"
Gawor270 Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"test:unit": "yarn workspaces foreach -Ap run test",
"test:e2e": "yarn workspaces foreach -A --include '@fishjam-e2e/*' run e2e",
"gen:proto": "yarn workspace @fishjam-cloud/protobufs gen:proto",
"tsc": "yarn workspaces foreach -Ap run tsc || echo '❌ Type errors! ❌' ",
"tsc": "yarn workspaces foreach -Ap run tsc",
"format:root": "prettier . --write",
"format:root:check": "prettier . --check",
"format": "yarn format:root & yarn workspaces foreach -A -p run format || echo '❌ Formatting issues! ❌'",
Expand Down
Loading