feature/country-region-reports by fivetran-joemarkiewicz · Pull Request #74 · fivetran/dbt_linkedin_source

fivetran-joemarkiewicz · 2025-04-23T21:24:58Z

PR Overview

Package version introduced in this PR: v0.11.0

This PR addresses the following Issue/Feature(s): Internal ticket

Summary of changes:

Adds new staging models for the geo, monthly_ad_analytics_by_member_country, and monthly_ad_analytics_by_member_region sources.

Submission Checklist

Alignment meeting with the reviewer (if needed)
- Timeline and validation requirements discussed
Provide validation details:
- Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
- Testing Instructions: Confirm the change addresses the issue(s)
- Focus Areas: Complex logic or queries that need extra attention

For all above validations and testing please see internal ticket. Additionally, docs have not be generated and will be once PR is near approval.

Changelog

Draft changelog for PR
Final changelog for release review

fivetran-jamie

looks great! left mostly doc-related comments

CHANGELOG.md

README.md

macros/get_monthly_ad_analytics_by_member_country_columns.sql

macros/get_monthly_ad_analytics_by_member_region_columns.sql

models/stg_linkedin_ads__monthly_ad_analytics_by_country.sql

models/stg_linkedin.yml

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>

fivetran-jamie

LGTM!

fivetran-avinash · 2025-04-28T21:55:48Z

CHANGELOG.md

+[PR #74](https://github.com/fivetran/dbt_linkedin_source/pull/74) includes the following updates:
+
+## Schema Changes
+**6 total changes • 0 possible breaking changes


To properly bold:

Suggested change

**6 total changes • 0 possible breaking changes

**6 total changes • 0 possible breaking changes**

fivetran-avinash · 2025-04-28T21:55:51Z

CHANGELOG.md

+**6 total changes • 0 possible breaking changes
+| Data Model                                      | Change Type | Old Name | New Name                                  | Notes                                                             |
+|---------------------------------------------------|-------------|----------|-------------------------------------------|-------------------------------------------------------------------|
+| stg_tiktok_ads__geo_tmp       | New temp model   |          |  | Temp model added for `geo`.               |


Similar comment to add the links to the DAG in the Data Model columns.

fivetran-avinash · 2025-04-28T21:59:02Z

CHANGELOG.md

+**6 total changes • 0 possible breaking changes
+| Data Model                                      | Change Type | Old Name | New Name                                  | Notes                                                             |
+|---------------------------------------------------|-------------|----------|-------------------------------------------|-------------------------------------------------------------------|
+| stg_tiktok_ads__geo_tmp       | New temp model   |          |  | Temp model added for `geo`.               |


fivetran-avinash · 2025-04-28T21:59:54Z

CHANGELOG.md

+| Data Model                                      | Change Type | Old Name | New Name                                  | Notes                                                             |
+|---------------------------------------------------|-------------|----------|-------------------------------------------|-------------------------------------------------------------------|
+| stg_tiktok_ads__geo_tmp       | New temp model   |          |  | Temp model added for `geo`.               |
+| stg_tiktok_ads__geo          | New staging model   |          |    | Staging model added for `geo`.         |


fivetran-avinash · 2025-04-28T22:04:08Z

macros/date_from_month_string.sql

Should we call out what this macro does in an Under the Hood CHANGELOG section?

Doesn't hurt to include, added an entry.

fivetran-avinash · 2025-04-28T22:09:44Z

models/src_linkedin.yml

+          - name: external_website_conversions
+            description: Number of conversions that occurred on an external website as a result of the ad.
+          - name: one_click_leads
+            description: Number of one-click leads generated from the ad campaign.
+          - name: external_website_conversions
+            description: The actions taken on your website that you've defined as valuable to your business after clicking on LinkedIn ads.
          - name: one_click_leads
            description: Leads submitted after clicking on LinkedIn ads.


These columns are duplicated. I think the second set of columns have better descriptions, so I'd opt to keep those, but will leave up to you!

Unsure how this happened. Removed.

fivetran-avinash · 2025-04-28T22:18:01Z

models/src_linkedin.yml

+          - name: external_website_conversions
+            description: Number of conversions that occurred on an external website as a result of the ad.
+          - name: one_click_leads
+            description: Number of one-click leads generated from the ad campaign.
+          - name: external_website_conversions
+            description: The actions taken on your website that you've defined as valuable to your business after clicking on LinkedIn ads.
+          - name: one_click_leads
+            description: Leads submitted after clicking on LinkedIn ads.


These columns are duplicated. I think the second set of columns have better descriptions, so I'd opt to keep those, but will leave up to you!

Unsure how this happened. Removed.

fivetran-avinash · 2025-04-28T22:18:40Z

models/stg_linkedin.yml

+      - name: external_website_conversions
+        description: Number of conversions that occurred on an external website as a result of the ad.
+      - name: one_click_leads
+        description: Number of one-click leads generated from the ad campaign.
+      - name: external_website_conversions
+        description: The actions taken on your website that you've defined as valuable to your business after clicking on LinkedIn ads.
+      - name: one_click_leads
+        description: Leads submitted after clicking on LinkedIn ads.


Same duplicate column issue, similar recommendation to use the second set.

Unsure how this happened. Removed.

fivetran-avinash · 2025-04-28T22:20:18Z

models/stg_linkedin.yml

+        description: The value generated by your conversions, displayed in your LinkedIn account's local currency.
+      - name: cost
+        description: The cost of the ads in the local currency or USD.
+      - name: external_website_conversions


Same duplicate column issue, similar recommendation to use the second set.

Unsure how this happened. Removed.

fivetran-avinash · 2025-04-28T22:24:58Z

README.md

We will want to apply line 139 with the new support for the new tables added I think, with a link to this upcoming release.

This was mainly just to call out the backwards compatibility at that point in time. It's not entirely necessary to include this release in that section since this is a net new model. However, I did update the section to callout the downstream components which the variable is used compatibile.

fivetran-avinash

@fivetran-joemarkiewicz Almost there! A few questions, comments and suggestions before release.

fivetran-avinash

lgtm

feature/country-region-reports

f66ee05

fivetran-joemarkiewicz self-assigned this Apr 23, 2025

additional updates

dd3fac4

fivetran-joemarkiewicz requested a review from fivetran-jamie April 24, 2025 04:05

fivetran-joemarkiewicz marked this pull request as ready for review April 24, 2025 04:07

fivetran-joemarkiewicz linked an issue Apr 24, 2025 that may be closed by this pull request

[Documentation] Move badges below H1 heading #72

Closed

4 tasks

fivetran-jamie reviewed Apr 25, 2025

View reviewed changes

fivetran-joemarkiewicz commented Apr 28, 2025

View reviewed changes

models/stg_linkedin.yml Show resolved Hide resolved

fivetran-joemarkiewicz commented Apr 28, 2025

View reviewed changes

models/stg_linkedin.yml Show resolved Hide resolved

fivetran-joemarkiewicz commented Apr 28, 2025

View reviewed changes

models/stg_linkedin.yml Show resolved Hide resolved

fivetran-joemarkiewicz and others added 2 commits April 28, 2025 08:41

Apply suggestions from code review

dc16c15

Co-authored-by: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com>

review updates and docs regen

53b071f

fivetran-joemarkiewicz requested a review from fivetran-jamie April 28, 2025 15:46

fivetran-jamie approved these changes Apr 28, 2025

View reviewed changes

changelog column change

32bd8c1

fivetran-avinash reviewed Apr 28, 2025

View reviewed changes

release review updates

436d04c

fivetran-avinash approved these changes Apr 28, 2025

View reviewed changes

requirements update

318da5d

fivetran-joemarkiewicz merged commit cc24d04 into main Apr 29, 2025
8 checks passed

	**6 total changes • 0 possible breaking changes
	6 total changes • 0 possible breaking changes

	\| stg_tiktok_ads__geo_tmp \| New temp model \| \| \| Temp model added for `geo`. \|
	\| stg_linkedin_ads__geo_tmp \| New temp model \| \| \| Temp model added for `geo`. \|

	\| stg_tiktok_ads__geo \| New staging model \| \| \| Staging model added for `geo`. \|
	\| stg_linkedin_ads__geo \| New staging model \| \| \| Staging model added for `geo`. \|

Conversation

fivetran-joemarkiewicz commented Apr 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Overview

Submission Checklist

Changelog

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fivetran-jamie left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash Apr 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

fivetran-avinash left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

fivetran-joemarkiewicz commented Apr 23, 2025 •

edited

Loading

fivetran-avinash Apr 28, 2025 •

edited

Loading

fivetran-avinash Apr 28, 2025 •

edited

Loading

fivetran-avinash Apr 28, 2025 •

edited

Loading