Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .quickstart/quickstart.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ table_variables:
netsuite2__multibook_accounting_enabled:
- accountingBook
- AccountingBookSubsidiaries
netsuite2__multibook_accounting_enabled_v2:
- AccountingBook
- AccountingBookSubsidiaries

# Source
netsuite2__using_account_types:
Expand Down
16 changes: 16 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,19 @@
# dbt_netsuite v1.5.0-a1

## Schema/Data Change (--full-refresh required after upgrading for affected connections)
**4 total changes • 4 possible breaking changes**

| Data Model(s) | Change type | Old | New | Notes |
| ------------- | ----------- | --- | --- | ----- |
| [netsuite2__transaction_details](https://fivetran.github.io/dbt_netsuite/#!/model/model.netsuite.netsuite2__transaction_details)<br>[netsuite2__balance_sheet](https://fivetran.github.io/dbt_netsuite/#!/model/model.netsuite.netsuite2__balance_sheet)<br>[netsuite2__income_statement](https://fivetran.github.io/dbt_netsuite/#!/model/model.netsuite.netsuite2__income_statement) | Data change | Values sourced from `accountingBook` | Values sourced from `AccountingBook` | Applies only to Quickstart connections where the connector now syncs the `AccountingBook` (PascalCase) table. |
| [netsuite2__transaction_details](https://fivetran.github.io/dbt_netsuite/#!/model/model.netsuite.netsuite2__transaction_details) | Data change | `transaction_details_id` | `transaction_details_id` | Applies only to Quickstart connections where the connector now syncs the `AccountingBook` (PascalCase) table. Surrogate key value changes for affected connections as `accounting_book_id` is now populated from the `AccountingBook` table. A full refresh is required. |
| [netsuite2__balance_sheet](https://fivetran.github.io/dbt_netsuite/#!/model/model.netsuite.netsuite2__balance_sheet) | Data change | `balance_sheet_id` | `balance_sheet_id` | Applies only to Quickstart connections where the connector now syncs the `AccountingBook` (PascalCase) table. Surrogate key value could change for affected connections as `accounting_book_id` is now populated from the `AccountingBook` table. A full refresh is required. |
| [netsuite2__income_statement](https://fivetran.github.io/dbt_netsuite/#!/model/model.netsuite.netsuite2__income_statement) | Data change | `income_statement_id` | `income_statement_id` | Applies only to Quickstart connections where the connector now syncs the `AccountingBook` (PascalCase) table. Surrogate key value could changes for affected connections as `accounting_book_id` is now populated from the `AccountingBook` table. A full refresh is required. |

## Under the Hood
- Adds `netsuite2__multibook_accounting_enabled_v2` table variable to `quickstart.yml` to detect customers syncing the `AccountingBook` table name instead of `accountingBook`.
- Updates all models that read `netsuite2__multibook_accounting_enabled` to also evaluate `netsuite2__multibook_accounting_enabled_v2`, ensuring multibook logic runs correctly for both connection variants during the connector migration period.

# dbt_netsuite v1.4.0

[PR #190](https://github.com/fivetran/dbt_netsuite/pull/190) includes the following updates:
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ Include the following netsuite package version in your `packages.yml` file:
```yaml
packages:
- package: fivetran/netsuite
version: [">=1.4.0", "<1.5.0"]
version: 1.5.0-a1
```

#### Databricks dispatch configuration
Expand Down
2 changes: 1 addition & 1 deletion dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
config-version: 2
name: 'netsuite'
version: '1.4.0'
version: '1.5.0'
require-dbt-version: [">=1.3.0", "<3.0.0"]

models:
Expand Down
2 changes: 1 addition & 1 deletion integration_tests/dbt_project.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: 'netsuite_integration_tests'
version: '1.4.0'
version: '1.5.0'
profile: 'integration_tests'
config-version: 2

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) -%}
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) or var('netsuite2__multibook_accounting_enabled_v2', false) -%}

{{ config(enabled=var('netsuite_data_model', 'netsuite') == var('netsuite_data_model_override','netsuite2')) }}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) -%}
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) or var('netsuite2__multibook_accounting_enabled_v2', false) -%}
{%- set using_to_subsidiary = var('netsuite2__using_to_subsidiary', false) -%}

{{ config(enabled=var('netsuite_data_model', 'netsuite') == var('netsuite_data_model_override','netsuite2') and var('netsuite2__using_exchange_rate', true)) }}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) -%}
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) or var('netsuite2__multibook_accounting_enabled_v2', false) -%}

{{ config(enabled=var('netsuite_data_model', 'netsuite') == var('netsuite_data_model_override','netsuite2')) }}

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{%- set using_exchange_rate = var('netsuite2__using_exchange_rate', true) -%}
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) -%}
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) or var('netsuite2__multibook_accounting_enabled_v2', false) -%}
{%- set using_to_subsidiary = var('netsuite2__using_to_subsidiary', false) -%}

{{
Expand Down
2 changes: 1 addition & 1 deletion models/netsuite2/netsuite2__balance_sheet.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) -%}
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) or var('netsuite2__multibook_accounting_enabled_v2', false) -%}
{%- set using_to_subsidiary_and_exchange_rate = (var('netsuite2__using_to_subsidiary', false) and var('netsuite2__using_exchange_rate', true)) -%}
{%- set balance_sheet_transaction_detail_columns = var('balance_sheet_transaction_detail_columns', []) -%}
{%- set accounts_pass_through_columns = var('accounts_pass_through_columns', []) -%}
Expand Down
2 changes: 1 addition & 1 deletion models/netsuite2/netsuite2__income_statement.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) -%}
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) or var('netsuite2__multibook_accounting_enabled_v2', false) -%}
{%- set using_to_subsidiary = var('netsuite2__using_to_subsidiary', false) -%}
{%- set using_exchange_rate = var('netsuite2__using_exchange_rate', true) -%}
{%- set income_statement_transaction_detail_columns = var('income_statement_transaction_detail_columns', []) -%}
Expand Down
2 changes: 1 addition & 1 deletion models/netsuite2/netsuite2__transaction_details.sql
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) -%}
{%- set multibook_accounting_enabled = var('netsuite2__multibook_accounting_enabled', false) or var('netsuite2__multibook_accounting_enabled_v2', false) -%}
{%- set using_to_subsidiary = var('netsuite2__using_to_subsidiary', false) -%}
{%- set using_exchange_rate = var('netsuite2__using_exchange_rate', true) -%}
{%- set using_vendor_categories = var('netsuite2__using_vendor_categories', true) -%}
Expand Down
4 changes: 2 additions & 2 deletions models/netsuite2/staging/src_netsuite2.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ sources:
identifier: "{{ var('netsuite2_accounting_book_subsidiaries_identifier', 'accountingbooksubsidiaries') }}"
description: "{{ doc('accounting_book_subsidiaries_table') }}"
config:
enabled: "{{ var('netsuite2__multibook_accounting_enabled', true) }}"
enabled: "{{ var('netsuite2__multibook_accounting_enabled', true) or var('netsuite2__multibook_accounting_enabled_v2', false) }}"
columns:
- name: _fivetran_id
description: "{{ doc('_fivetran_id') }}"
Expand All @@ -51,7 +51,7 @@ sources:
identifier: "{{ var('netsuite2_accounting_book_identifier', 'accountingbook') }}"
description: "{{ doc('accounting_books_table') }}"
config:
enabled: "{{ var('netsuite2__multibook_accounting_enabled', true) }}"
enabled: "{{ var('netsuite2__multibook_accounting_enabled', true) or var('netsuite2__multibook_accounting_enabled_v2', false) }}"
columns:
- name: _fivetran_synced
description: "{{ doc('_fivetran_synced') }}"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
config(
enabled=(
var('netsuite_data_model', 'netsuite') == var('netsuite_data_model_override','netsuite2')
and var('netsuite2__multibook_accounting_enabled', true)
and (var('netsuite2__multibook_accounting_enabled', true) or var('netsuite2__multibook_accounting_enabled_v2', false))
)
)
}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
config(
enabled=(
var('netsuite_data_model', 'netsuite') == var('netsuite_data_model_override','netsuite2')
and var('netsuite2__multibook_accounting_enabled', true)
and (var('netsuite2__multibook_accounting_enabled', true) or var('netsuite2__multibook_accounting_enabled_v2', false))
)
)
}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
config(
enabled=(
var('netsuite_data_model', 'netsuite') == var('netsuite_data_model_override','netsuite2')
and var('netsuite2__multibook_accounting_enabled', true)
and (var('netsuite2__multibook_accounting_enabled', true) or var('netsuite2__multibook_accounting_enabled_v2', false))
)
)
}}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
config(
enabled=(
var('netsuite_data_model', 'netsuite') == var('netsuite_data_model_override','netsuite2')
and var('netsuite2__multibook_accounting_enabled', true)
and (var('netsuite2__multibook_accounting_enabled', true) or var('netsuite2__multibook_accounting_enabled_v2', false))
)
)
}}
Expand Down