This repository was archived by the owner on Jan 15, 2026. It is now read-only.
feature/update-freshness-config#95
Closed
fivetran-joemarkiewicz wants to merge 3 commits into
Closed
Conversation
Contributor
fivetran-jamie
left a comment
fivetran-jamie
left a comment
There was a problem hiding this comment.
Overall looks good -- just need to update the dbt version to be 1.9.6 instead of 1.9.5 and the table-level freshness configs
|
|
||
| [PR #95](https://github.com/fivetran/dbt_stripe_source/pull/95) includes the following updates: | ||
|
|
||
| ## Breaking Change for dbt Core < 1.9.5 |
Contributor
There was a problem hiding this comment.
Suggested change
| ## Breaking Change for dbt Core < 1.9.5 | |
| ## Breaking Change for dbt Core < 1.9.6 |
|
|
||
| ## Breaking Change for dbt Core < 1.9.5 | ||
| > *Note: This is not relevant to Fivetran Quickstart users.* | ||
| Migrated `freshness` from a top-level source property to a source `config` in alignment with [recent updates](https://github.com/dbt-labs/dbt-core/issues/11506) from dbt Core. This will resolve the following deprecation warning that users running dbt >= 1.9.5 may have received: |
Contributor
There was a problem hiding this comment.
Suggested change
| Migrated `freshness` from a top-level source property to a source `config` in alignment with [recent updates](https://github.com/dbt-labs/dbt-core/issues/11506) from dbt Core. This will resolve the following deprecation warning that users running dbt >= 1.9.5 may have received: | |
| Migrated `freshness` from a top-level source property to a source `config` in alignment with [recent updates](https://github.com/dbt-labs/dbt-core/issues/11506) from dbt Core. This will resolve the following deprecation warning that users running dbt >= 1.9.6 may have received: |
| into the `config` of `stripe`. | ||
| ``` | ||
|
|
||
| **IMPORTANT:** Users running dbt Core < 1.9.5 will not be able to utilize freshness tests in this release or any subsequent releases, as older versions of dbt will not recognize freshness as a source `config` and therefore not run the tests. |
Contributor
There was a problem hiding this comment.
Suggested change
| **IMPORTANT:** Users running dbt Core < 1.9.5 will not be able to utilize freshness tests in this release or any subsequent releases, as older versions of dbt will not recognize freshness as a source `config` and therefore not run the tests. | |
| **IMPORTANT:** Users running dbt Core < 1.9.6 will not be able to utilize freshness tests in this release or any subsequent releases, as older versions of dbt will not recognize freshness as a source `config` and therefore not run the tests. |
|
|
||
| **IMPORTANT:** Users running dbt Core < 1.9.5 will not be able to utilize freshness tests in this release or any subsequent releases, as older versions of dbt will not recognize freshness as a source `config` and therefore not run the tests. | ||
|
|
||
| If you are using dbt Core < 1.9.5 and want to continue running Stripe freshness tests, please elect **one** of the following options: |
Contributor
There was a problem hiding this comment.
Suggested change
| If you are using dbt Core < 1.9.5 and want to continue running Stripe freshness tests, please elect **one** of the following options: | |
| If you are using dbt Core < 1.9.6 and want to continue running Stripe freshness tests, please elect **one** of the following options: |
| **IMPORTANT:** Users running dbt Core < 1.9.5 will not be able to utilize freshness tests in this release or any subsequent releases, as older versions of dbt will not recognize freshness as a source `config` and therefore not run the tests. | ||
|
|
||
| If you are using dbt Core < 1.9.5 and want to continue running Stripe freshness tests, please elect **one** of the following options: | ||
| 1. (Recommended) Upgrade to dbt Core >= 1.9.5 |
Contributor
There was a problem hiding this comment.
Suggested change
| 1. (Recommended) Upgrade to dbt Core >= 1.9.5 | |
| 1. (Recommended) Upgrade to dbt Core >= 1.9.6 |
| - Materializes [Stripe staging tables](https://fivetran.github.io/dbt_stripe_source/#!/overview/stripe_source/models/?g_v=1&g_e=seeds) which leverage data in the format described by [this ERD](https://fivetran.com/docs/applications/stripe/#schemainformation). These staging tables clean, test, and prepare your Stripe data from [Fivetran's connector](https://fivetran.com/docs/applications/stripe) for analysis by doing the following: | ||
| - Name columns for consistency across all packages and for easier analysis | ||
| - Adds freshness tests to source data | ||
| > dbt Core >= 1.9.5 is required to run freshness tests out of the box. See other options [here](https://github.com/fivetran/dbt_stripe_source/blob/main/CHANGELOG.md#breaking-change-for-dbt-core--195). |
Contributor
There was a problem hiding this comment.
Suggested change
| > dbt Core >= 1.9.5 is required to run freshness tests out of the box. See other options [here](https://github.com/fivetran/dbt_stripe_source/blob/main/CHANGELOG.md#breaking-change-for-dbt-core--195). | |
| > dbt Core >= 1.9.6 is required to run freshness tests out of the box. See other options [here](https://github.com/fivetran/dbt_stripe_source/blob/main/CHANGELOG.md#breaking-change-for-dbt-core--196). |
| freshness: | ||
| warn_after: { count: 72, period: hour } | ||
| error_after: { count: 168, period: hour } | ||
| config: |
Contributor
There was a problem hiding this comment.
Gotta update the table-level freshness configs as well
Contributor
Author
|
This was addressed within PR #96 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Overview
Package version introduced in this PR:
v0.15.0This PR addresses the following Issue/Feature(s): Issue #94
Summary of changes:
Updates freshness to align with the new config framework introduced in dbt Core v1.9.5. Documents how users on older versions of dbt Core will/can interface with freshness
Submission Checklist
Validation Steps: Check for unintentional effects (e.g., add/run consistency & integrity tests)
Testing Instructions: Confirm the change addresses the issue(s)
Focus Areas: Complex logic or queries that need extra attention
Changelog