This repository was archived by the owner on Sep 5, 2025. It is now read-only.
Hold write lock during fs remove in gc#39
Closed
jgrund wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Joe Grund <jgrund@whamcloud.io>
Contributor
|
I don't think this actually solves the underlying issue, where you can hold a value handle, then the blob file gets rewritten, then you resolve the value handle. Also the read lock is only held shortly, so it could still read the file while not being locked. |
Contributor
|
FWIW if the read lock was extended, it would probably solve the race condition here in value-log, but lsm-tree can probably still crash under certain circumstances (https://github.com/fjall-rs/lsm-tree/blob/main/src%2Fblob_tree%2Fmod.rs#L47). Basically you when you retrieve a value handle, you get locked out by GC and suddenly the blob file is gone. |
Author
|
Thanks, I wasn't sure if I got the whole solution or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change holds the segement write lock while we remove stale files from the fs. This resolves a race condition where reads can try to reference files that no longer exist on disk.
Fixes #38