Stop processing ScrollTimeline props if no animation-related properties have been declared#154
Merged
kevers-google merged 2 commits intoflackr:masterfrom Sep 13, 2023
Merged
Conversation
…re are none declared
kevers-google
requested changes
Sep 13, 2023
Collaborator
kevers-google
left a comment
There was a problem hiding this comment.
Format nit. Let's keep to Google style guidelines.
if (...) {
return;
}
space after if and statement on a separate line with {} even though 1 line. I'm sure, that I've violated this elsewhere, but no sense proliferating inconsistencies.
kevers-google
approved these changes
Sep 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging something for #153, I noticed that
saveInRelationListwas being called once per ruleset – even though only 1 of the processed ruleset in my test had animation-related properties declared.This PR adds a quick perf win by bailing out early from the
handleScrollTimelinePropsmethod in case no animation-related properties have been extracted.